This repository has been archived by the owner on Aug 23, 2023. It is now read-only.
457 experiment #487
Closed
457 experiment #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refers to ticket #457
- does aggmetric call the cache push callback every time a metric gets evicted from the ring buffer? - does aggmetric add the chunk into the store if the node is primary? - makes the devnullStore count how many times it's Add() got called - does aggmetric not add the chunk into the store if the node is not primary?
this lets us simplify the unit tests and focus them on their business logic
|
I agree that the first commit is nice. Regarding the second one I'm not sure what the purpose of it is. I see that the test gets simplified by a small difference, because the callback lambda doesn't need to be instantiated in the test anymore and the test doesn't need to count the number of times |
replay
force-pushed
the
457
branch
2 times, most recently
from
55bd1b0
to
a068096
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@replay I think the first commit here is good. the second I have mixed feelings about. on one hand i disliked the mixed accounting logic (especially for hot adds) in both mockcache as well as the test, on the other hand, the new code is a tad more complex/verbose than what i would have liked :(
anyway just something i wanted to try and see how it looked. curious if you lean one way or the other.